examples/sotest: support packaged shared library fixtures#3526
examples/sotest: support packaged shared library fixtures#3526aviralgarg05 wants to merge 6 commits into
Conversation
c0ea45a to
52dcaa6
Compare
|
@aviralgarg05 and this one here? |
|
@aviralgarg05 what about CMakeLists.txt doesn't it need to be modified as well? |
|
Sorry, I missed the matching |
Add the shared-library package index and launch script fixtures used by the packaged sotest flow, covering the install metadata and staged execution path. Format the helper generator with black so it matches the current apps lint checks. Signed-off-by: aviralgarg05 <gargaviral99@gmail.com>
abe0cdf to
450bd87
Compare
Add the CMake-side build rules needed for the packaged shared-library sotest flow so it matches the existing Makefile behavior. This wires in the generated symbol table, ROMFS image, and packaged fixture artifacts for the shared-library test path. Signed-off-by: aviralgarg05 <gargaviral99@gmail.com>
0e0f392 to
469d1f8
Compare
Use the correct helper target names in the CMake sotest fixture rules so that the generated ROMFS assets depend on the shared-library test outputs in both ELF and non-ELF compiler paths. Signed-off-by: aviralgarg05 <gargaviral99@gmail.com>
469d1f8 to
76ab80f
Compare
90ad20d to
7bb6f87
Compare
Replace the shell-based CMake fixture generation with Python helpers\nso the generated symtab and ROMFS sources are produced in a\nportable way across the supported build hosts.\n\nThis keeps the sotest packaged shared-library fixture flow aligned\nwith the existing Makefile path while making the generated outputs\nexplicit to CMake. Signed-off-by: aviralgarg05 <gargaviral99@gmail.com>
7bb6f87 to
49d5f70
Compare
|
I checked the failing run, and this one does not seem to be caused by the patch itself. The failure is happening while the CI job tries to pull the shared container image from ghcr.io, before the actual build/test steps start. Since multiple matrix jobs are failing at that stage, this looks more like an infrastructure/network issue than a code issue in this PR. @acassis Can you pls help me understand if there is something wrong with my code |
Don't worry, it is a github failure, I just restart the Job |
231083e to
5836877
Compare
Keep the Python-based fixture generation in the CMake path, but use the shell wrapper in the Makefile path as requested in review. This keeps the Make-based flow aligned with the existing shell-driven build rules without changing the generated shared-fixture outputs. Signed-off-by: aviralgarg05 <gargaviral99@gmail.com>
5836877 to
f24da1e
Compare
linguini1
left a comment
There was a problem hiding this comment.
After reading the description and reviewing your code, I'm still uncertain what this PR is doing? Is this to make sotest a loadable application through nxpkg?
This PR includes Python scripts as part of the build process, which I remember was a contentious issue. Is it okay to enforce that the user has Python for this?
|
I pushed an update for this. The Python generators added by this PR are removed now. The shared fixture helper is now a small C host tool, and the CMake path no longer introduces Python into the build flow. Also, the goal here is not to make |
|
Can you explain what a "package-style fixture producer" is? I'm not sure I really understand, sorry. Also, please squash your commits. |
Replace the Python-based sotest fixture helpers with a small host-side C tool so the generated packaged shared-library fixtures do not depend on Python at build time.\n\nKeep the generated helper and CMake rules formatted to match the current apps lint checks. Signed-off-by: aviralgarg05 <gargaviral99@gmail.com>
2ca1c72 to
40329b7
Compare
|
By “package-style fixture producer”, I mean the small host-side helper that generates the test package metadata and script files for the packaged sotest flow. In this case it takes the built shared-library artifacts and writes the fixture files used by nxpkg, so the packaged install/run path is exercised as part of the example instead of only the plain builtin layout. |
What is the packaged sotest flow? Like installing sotest from a package? |
|
Yes, exactly. |
|
It doesn't really seem sustainable to have host side tools for every application in order to generate these files. It should probably be a central build tool that works for making any package compatible with nxpkg |
|
For this PR, I was trying to keep the scope limited to replacing the Python dependency in the existing example-local fixture path. I agree the better long-term direction is a shared build helper for nxpkg-compatible fixture generation, instead of per-example host tools. I can keep this PR scoped as-is and we can follow up with that cleanup separately. |
But that doesn't make sense, because this PR is what added the Python dependency? So there was nothing to remove, just a change in your implementation of the patch.
I think it would be better to start your feature correctly to make it easier for you to package more applications later, but if it's easier then it's okay to put this one in using C-based host tools. Also another thing for later would be to included a SHA hash library instead of rolling your own. But I think it's fine for this PR! |
Summary
This patch is another smaller upstream slice being extracted from the ongoing GSoC 2026 Dynamic ELF loading and
nxpkgwork for NuttX.An earlier draft PR (#3474) carries the initial
nxpkgpackage lifecycle helper. PR #3519 carries a separateapps/module-support cleanup slice from the same broader effort. This PR is independent of #3519, but can still be reviewed after it to keep the follow-up series orderly.Series order for this PR:
The change itself extends the
examples/sotestpackaging path so the shared-library test fixtures can also be prepared throughnxpkg-style package artifacts.Concretely, it:
shared-index.jsonandpkgsotest.nshfrom the builtmodprintandsotestshared objectsarch/compatmetadata and SHA-256 digests for those packaged shared-library fixturessotestto run in either its existing builtin-ROMFS flow or from explicit shared-library paths, with a--mounthelper mode for preparing the builtin test mount separatelyImpact
This makes the
sotestshared-library example usable as a package-style fixture producer for the same Dynamic ELF /nxpkgseries.That is useful for validating the shared-library side of the packaging flow, where the loader should consume installed artifacts rather than only the default builtin test paths.
There is no intended regression for the normal
sotestexample flow. The existing builtin-ROMFS path is preserved, while the test binary now also accepts explicit shared-library paths when the package-installed copies need to be exercised.Keeping this work separate from the larger series should make review easier, while still preserving the intended merge order after #3474.
Testing
Host:
arm64)xtensa-esp-elf-gcc (crosstool-NG esp-14.2.0_20241119) 14.2.0esptool.py v4.11.0Focused verification for this PR:
appsworktree with this patch stacked on top of the current#3474headapache/nuttxworktree at the localboards/xtensa/esp32s3/xiao:sotest: enable nxpkg fixturescommit used for the matching XIAO configurationxtensaesp32s3-xiao:sotestBuild steps:
Generated fixture artifacts:
Build result:
Broader series context:
nxpkgseries has been validated separately on the Seeed XIAO ESP32S3 Sense during the ongoing bring-up work, but this PR description is intentionally limiting its direct claim to the focused stacked verification above