Skip to content

fix(ci): propagate failures from multi-project hooks#3743

Open
Standing-Man wants to merge 4 commits into
apache:masterfrom
Standing-Man:java-gradle-check
Open

fix(ci): propagate failures from multi-project hooks#3743
Standing-Man wants to merge 4 commits into
apache:masterfrom
Standing-Man:java-gradle-check

Conversation

@Standing-Man

@Standing-Man Standing-Man commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Which issue does this PR address?

Closes #
Relates to #

Rationale

The Java, Go, and Node hooks executed multiple projects in shell loops without fail-fast behavior. When an earlier project failed but a later project passed, the loop returned a successful exit status and allowed the commit or push to continue.

What changed?

  • make java-gradle-check stop on the first Gradle failure
  • make go-fmt stop on the first formatting failure
  • make go-mod-tidy stop when go mod tidy changes files or fails
  • make node-eslint stop on the first dependency installation or lint failure
  • replace conditional && loop bodies with explicit if blocks
  • enable bash -e for all affected hooks

Local Execution

  • Passed / not passed
    Passed
  • Pre-commit hooks ran / not ran
    Ran

AI Usage

Signed-off-by: StandingMan <jmtangcs@gmail.com>
Signed-off-by: StandingMan <jmtangcs@gmail.com>
@github-actions

Copy link
Copy Markdown

Thanks for the PR. It is labeled S-waiting-on-review and queued for review.

Slash commands (own line, regular comment) move it around the queue:

  • /ready - back to S-waiting-on-review after addressing feedback
  • /author - flip to S-waiting-on-author while you finish changes
  • /request-review @user-or-team - request a reviewer

See CONTRIBUTING.md for details.

@github-actions github-actions Bot added the S-waiting-on-review PR is waiting on a reviewer label Jul 23, 2026
@Standing-Man
Standing-Man marked this pull request as draft July 24, 2026 02:30
@github-actions github-actions Bot removed the S-waiting-on-review PR is waiting on a reviewer label Jul 24, 2026
@Standing-Man Standing-Man changed the title fix(ci): propagate Java Gradle hook failures fix(ci): propagate failures from multi-project hooks Jul 24, 2026
@Standing-Man
Standing-Man marked this pull request as ready for review July 24, 2026 04:47
@github-actions github-actions Bot added the S-waiting-on-review PR is waiting on a reviewer label Jul 24, 2026
Signed-off-by: StandingMan <jmtangcs@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review PR is waiting on a reviewer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants