fix(ci): propagate failures from multi-project hooks#3743
Open
Standing-Man wants to merge 4 commits into
Open
Conversation
Signed-off-by: StandingMan <jmtangcs@gmail.com>
Signed-off-by: StandingMan <jmtangcs@gmail.com>
|
Thanks for the PR. It is labeled Slash commands (own line, regular comment) move it around the queue:
See CONTRIBUTING.md for details. |
Standing-Man
marked this pull request as draft
July 24, 2026 02:30
Standing-Man
marked this pull request as ready for review
July 24, 2026 04:47
Signed-off-by: StandingMan <jmtangcs@gmail.com>
mmodzelewski
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR address?
Closes #
Relates to #
Rationale
The Java, Go, and Node hooks executed multiple projects in shell loops without fail-fast behavior. When an earlier project failed but a later project passed, the loop returned a successful exit status and allowed the commit or push to continue.
What changed?
java-gradle-checkstop on the first Gradle failurego-fmtstop on the first formatting failurego-mod-tidystop whengo mod tidychanges files or failsnode-eslintstop on the first dependency installation or lint failure&&loop bodies with explicitifblocksbash -efor all affected hooksLocal Execution
Passed
Ran
AI Usage