perf(table): load equality deletes lazily per scan task - #1963
Open
fallintoplace wants to merge 2 commits into
Open
perf(table): load equality deletes lazily per scan task#1963fallintoplace wants to merge 2 commits into
fallintoplace wants to merge 2 commits into
Conversation
Signed-off-by: Minh Vu <vuhoangminh97@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The old path read every unique equality-delete file before returning the iterator. This change only reads files needed by tasks that are actually processed.
Benchmark
Setup: 10,000 scan tasks, 1,000 equality-delete files, 10 keys per file, 16 workers. Three runs with
-benchtime=1son an Apple M1 Pro.Tests
go test ./table -count=1go test -race ./table -count=1go vet ./table