fix: DatabaseJoin dialog NPE when the configured connection no longer exists - #8110
Open
waterWang wants to merge 1 commit into
Open
fix: DatabaseJoin dialog NPE when the configured connection no longer exists#8110waterWang wants to merge 1 commit into
waterWang wants to merge 1 commit into
Conversation
… exists HOP-8095: Database join transform throws NullPointerException if the connection no longer exists. pipelineMeta.findDatabase() returns null for a stale connection reference, and getSqlReservedWords() dereferences it unconditionally. Return an empty reserved-words list when the database is missing, keeping the dialog openable so the connection can be fixed.
Contributor
|
Thank you for the contribution @waterWang |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8095
DatabaseJoinDialog.getSqlReservedWords()dereferences the result ofpipelineMeta.findDatabase()without a null check. When the configured connection no longer exists,findDatabase()returnsnullanddatabaseMeta.getReservedWords()throwsNullPointerException, making the transform impossible to reopen.This matches the existing null check in the dialog's
ok()method. When the database is missing,getSqlReservedWords()now returns an empty list so the dialog stays open and the connection can be fixed.