feat(action): support hidden arguments in Shell action to prevent credential leaks in execution logs (#4935) - #8094
Open
zanarellidev wants to merge 2 commits into
Conversation
… Shell action logs (apache#4935)
Contributor
|
Please remove method |
…ard compatibility tests
Contributor
Author
|
Hi @mattcasters, thank you for the review! I have updated the PR according to your feedback:
All tests and spotless checks pass cleanly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4935.
When running Shell actions with arguments (e.g. API keys, database credentials, passwords, or tokens), Hop currently logs the raw execution command with all arguments visible in the execution log at
BASIClog level. This creates a security risk / credential exposure in log sinks, execution history, and UI logs.This PR adds support for Hidden Arguments in the Shell Action:
ActionShell.ShellArgumentwithvalueandhiddenproperties.loadXml).***in execution log outputs (logBasic), while preserving raw unmasked argument values for the operating system process execution viaProcessBuilder.Hidden (Y/N)CCombo column inActionShellDialogfor easy GUI configuration.WorkflowActionShellLoadSaveTest.javacoveringShellArgumentserialization and hidden flag behavior. All 8 tests in the module pass cleanly.Testing
mvn testThank you for your review!