feat(collector): support milvus collector (#3877) - #4303
Draft
paultanay wants to merge 6 commits into
Draft
Conversation
github-actions
Bot
added
doc
paultanay
marked this pull request as ready for review
August 8, 2026 16:18
Duansg
requested changes
Aug 9, 2026
| * Scrapes the Prometheus-format /metrics endpoint exposed by Milvus on port 9091. | ||
| */ | ||
| @Slf4j | ||
| public class MilvusCollectImpl extends AbstractCollect { |
Member
There was a problem hiding this comment.
Thank you for your work! Before going further, could we reconsider the approach?
Milvus exposes a standard Prometheus /metrics endpoint, and HertzBeat already handles that with protocol: http + parseType: prometheus. Going that route would let app-milvus.yml work without a new hertzbeat-collector-milvus module, a new MilvusProtocol, or changes to Metrics.java / DispatchConstants.
Contributor
Author
There was a problem hiding this comment.
Thanks for the clear guidance @Duansg! reworked the implementation to use protocol: http with parseType: prometheus. Please take another look!
Duansg
marked this pull request as draft
August 9, 2026 15:42
paultanay
force-pushed
the
feature/milvus-collector
branch
from
August 11, 2026 18:14
f64a96f to
443ebdb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changed
hertzbeat-collector-milvusmodule to scrape Prometheus metrics from Milvus (/metricsendpoint on port 9091).MilvusProtocolentity inhertzbeat-common-core.app-milvus.ymlcovering availability, proxy, querynode, and rootcoord metrics.AbstractCollect.home/docs/help/milvus.md).MilvusCollectImplTest,MilvusProtocolTest).Fixes #3877