Skip to content

HBASE-30127 Improve Website's SEO#8157

Open
yuriipalam wants to merge 8 commits into
apache:masterfrom
yuriipalam:HBASE-30127
Open

HBASE-30127 Improve Website's SEO#8157
yuriipalam wants to merge 8 commits into
apache:masterfrom
yuriipalam:HBASE-30127

Conversation

@yuriipalam
Copy link
Copy Markdown
Contributor

@yuriipalam yuriipalam commented Apr 28, 2026

There is also a small change in the hbase-site repo, please take a look:
apache/hbase-site#13

This change improves SEO (Search Engine Optimization) by adding proper cache headers, good looking 404 page, and sitemap.

404 page in dark mode:
image

Copy link
Copy Markdown
Contributor

@PDavid PDavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks, looks really nice already. 👍

Just two small questions / comments.

Comment thread hbase-website/public/sitemap.xml Outdated
Comment thread hbase-website/package.json Outdated
@PDavid
Copy link
Copy Markdown
Contributor

PDavid commented Apr 28, 2026

It seems that the build complains about these files missing the ASF licence header:

Files with unapproved licenses:

public/robots.txt
public/sitemap.xml

Copy link
Copy Markdown
Contributor

@PDavid PDavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks, looks good to me. 👍

@PDavid
Copy link
Copy Markdown
Contributor

PDavid commented Apr 29, 2026

Some tests failed in the PR build but they are not because of the changes in this branch.


[^2]: See http://docs.oracle.com/javase/specs/jls/se8/html/jls-13.html.

[^3]: Note that this indicates what could break, not that it will break. We will/should add specifics in our release notes.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I ask why did we remove this footnote from here? It seems to be unrelated to the website SEO to me.

Copy link
Copy Markdown
Contributor Author

@yuriipalam yuriipalam May 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because this footnote was added to the heading, what leads to a nested link problem.
In docs frameworks headings are links because they are anchors, same for footnotes.
So we had something like

<a>
  <h4>Heading...</h4>
  <a>^3</a>
<a>

It's wrong HTML structure which leads to a hydration error. Due to the async nature of the e2e tests, we couldn't reliably catch this issue before. It might be a new task to work on for me actually, to make it more deterministic.

So, I just moved the footnote right under the heading since it's the only place where it's used. This way we fix the broken structure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants