HADOOP-19854: ABFS. Namespace Detection for FNS Accounts with Soft Delete Enabled#8410
Open
manika137 wants to merge 3 commits intoapache:trunkfrom
Open
HADOOP-19854: ABFS. Namespace Detection for FNS Accounts with Soft Delete Enabled#8410manika137 wants to merge 3 commits intoapache:trunkfrom
manika137 wants to merge 3 commits intoapache:trunkfrom
Conversation
Contributor
Author
Test Results============================================================
|
|
🎊 +1 overall
This message was automatically generated. |
anujmodi2021
requested changes
Apr 9, 2026
Contributor
anujmodi2021
left a comment
anujmodi2021
left a comment
There was a problem hiding this comment.
Need test imprvements
| /* | ||
| * HTTP_CONFLICT with soft delete not supported error indicates a FNS account. | ||
| * This occurs when: | ||
| * 1. FNS-Blob endpoint is used (used with DFS endpoint for getAcl call) |
Contributor
There was a problem hiding this comment.
nit: used coming twice
| * This occurs when: | ||
| * 1. FNS-Blob endpoint is used (used with DFS endpoint for getAcl call) | ||
| * 2. FNS-DFS endpoint is used (later internally converted to Blob) | ||
| * For both cases, namespace should be disabled. No need to throw exception. |
Contributor
There was a problem hiding this comment.
Also add a line that for both cases ultimately Blob endpoint will be used so this error is irrelevant as it comes only on DFS Endpoint
| statusCode, null, errorMsg, null); | ||
| doThrow(ex).when(mockClient).getAclStatus(anyString(), any(TracingContext.class)); | ||
|
|
||
| if (isExceptionExpected) { |
Contributor
There was a problem hiding this comment.
Need some more testing no just mock.
I understand that we can't control account's soft-delete feature but let's run all the integration tests on an account where soft-delete is enabled if not already done.
And in integration tests we can assert that if error code returned by server can either be Bad request of htp conflict.
Contributor
Author
There was a problem hiding this comment.
Sure, will add integration tests
I have run the test suite with account's soft-delete enabled as well. Apart from the list failing (with startfrom param) that we have a fix coming up for- we're good
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
JIRA: https://issues.apache.org/jira/browse/HADOOP-19854
If fs.azure.account.hns.enabled is not configured, ABFS driver issues a getAcl call using the DFS endpoint to detect the account type (HNS or FNS)
For FNS Blob accounts with Soft Delete enabled, this behavior leads to failures because the DFS endpoint used does not support Soft Delete semantics.
Temporary fix is to explicitly set the configuration: fs.azure.account.hns.enabled so the redundant DFS-based detection is bypassed and the issue does not occur.
Raising PR for the code fix
How was this patch tested?
Test suite was run. Adding the results in the comments below