[VL] Re-enable some decimal tests#12287
Open
zhztheplayer wants to merge 1 commit into
Open
Conversation
The tests were disabled by facebookincubator/velox#17593 which was fixed.
|
Run Gluten Clickhouse CI on x86 |
Contributor
There was a problem hiding this comment.
Pull request overview
Re-enables previously excluded Spark UT cases around casting from string to decimal for the Velox backend, based on the upstream Velox fix referenced in the PR description.
Changes:
- Removed exclusions for “Fast fail for cast string type to decimal type” (non-ANSI).
- Removed exclusions for “Fast fail for cast string type to decimal type in ansi mode” (ANSI).
- Applied the same re-enable across Spark 3.3, 3.4, 3.5, 4.0, and 4.1 UT configurations.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| gluten-ut/spark41/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala | Re-enables the decimal fast-fail cast tests by removing excludes. |
| gluten-ut/spark40/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala | Re-enables the decimal fast-fail cast tests by removing excludes. |
| gluten-ut/spark35/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala | Re-enables the decimal fast-fail cast tests by removing excludes. |
| gluten-ut/spark34/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala | Re-enables the decimal fast-fail cast tests by removing excludes. |
| gluten-ut/spark33/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala | Re-enables the decimal fast-fail cast tests by removing excludes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tests were disabled by facebookincubator/velox#17593 which was fixed. We can now re-enable them.