LanceLakeWriter#close does not clear allFragments#3333
Closed
vamossagar12 wants to merge 2 commits into
Closed
Conversation
Contributor
Author
|
@polyzos can you PTAL at this small PR. |
Contributor
Author
|
This looks like a non-issue. Closing for now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #3332
In LanceLakeWriter.java#close(), allFragments still holds references to FragmentMetadata objects. If complete() is called after close(), it would return stale fragments. While the lifecycle should prevent this, clearing the list in close() is defensive best practice.
Brief change log
The fix is simple, clear
allFramgmentswhen close() is invoked in LanceLakeWriter.Tests
Added a unit test
API and Format
Documentation