[client] Fix inverted awaitTermination condition in LookupClient#close#3328
Open
XuQianJin-Stars wants to merge 1 commit into
Open
[client] Fix inverted awaitTermination condition in LookupClient#close#3328XuQianJin-Stars wants to merge 1 commit into
XuQianJin-Stars wants to merge 1 commit into
Conversation
The shutdown logic in LookupClient#close() had the awaitTermination condition inverted - it called shutdownNow() when the thread pool had already terminated gracefully, and did nothing when it timed out. This is inconsistent with WriterClient#close() and all other shutdown patterns in the codebase which correctly negate awaitTermination() to trigger shutdownNow() on timeout. The bug could cause the lookup sender thread pool to not be forcefully terminated when graceful shutdown times out, potentially leading to resource leaks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The shutdown logic in
LookupClient#close()had the awaitTermination condition inverted - it calledshutdownNow()when the thread pool had already terminated gracefully, and did nothing when it timed out.This is inconsistent with
WriterClient#close()and all other shutdown patterns in the codebase which correctly negateawaitTermination()to trigger shutdownNow() on timeout.The bug could cause the lookup sender thread pool to not be forcefully terminated when graceful shutdown times out, potentially leading to resource leaks.
Purpose
Fix a logic bug in
LookupClient#close()where a missing!operator caused inverted shutdown behavior for the lookup sender thread pool.Brief change log
awaitTermination()condition inLookupClient#close()by adding the missing!negation operator, making it consistent withWriterClient#close()and the standardExecutorServiceshutdown pattern documented in the Java SE docs.Tests
!) to an existing condition.WriterClient#close()andRemoteLogManager#shutdownAndAwaitTermination().API and Format
Documentation