[Fix-176][Python] Resolve task_type "K8S" in YAML workflow loader and…#177
Open
initiallyqq wants to merge 1 commit into
Open
[Fix-176][Python] Resolve task_type "K8S" in YAML workflow loader and…#177initiallyqq wants to merge 1 commit into
initiallyqq wants to merge 1 commit into
Conversation
… fix Kubernetes.yaml example The YAML workflow loader resolved task types by class name only, so task_type: K8S (TaskType.KUBERNETES) failed with PyDSTaskNoFoundException: cant not find task K8S. The shipped Kubernetes.yaml example also used camelCase fields rejected by the Kubernetes task constructor, and was the only example excluded from CI. - yaml_workflow.py: add _TASK_TYPE_ALIAS fallback so K8S resolves to the Kubernetes class; class-name matching is still tried first. - Kubernetes.yaml: minCpuCores/minMemorySpace -> snake_case. - test_yaml_workflow.py: cover K8S/k8s/Kubernetes in test_get_task and add Kubernetes.yaml to test_get_create_workflow. closes apache#176
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… fix Kubernetes.yaml example
The YAML workflow loader resolved task types by class name only, so task_type: K8S (TaskType.KUBERNETES) failed with
PyDSTaskNoFoundException: cant not find task K8S. The shipped Kubernetes.yaml example also used camelCase fields rejected by the Kubernetes task constructor, and was the only example excluded from CI.
closes #176
Brief Summary of The Change
Pull Request checklist
I confirm that the following checklist has been completed.
docs/source/config.rstwhen you change filedefault_config.yaml.UPDATING.mdwhen it is an incompatible change.