fix(proto): destructure JSON source and sink serde hooks - #24945
Open
buraksenn wants to merge 2 commits into
Open
fix(proto): destructure JSON source and sink serde hooks#24945buraksenn wants to merge 2 commits into
buraksenn wants to merge 2 commits into
Conversation
github-actions
Bot
added
proto
|
Thank you for opening this pull request! Reviewer note: cargo-semver-checks reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). Details |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #24945 +/- ##
==========================================
+ Coverage 81.52% 81.58% +0.06%
==========================================
Files 1123 1123
Lines 405970 410945 +4975
Branches 405970 410945 +4975
==========================================
+ Hits 330983 335287 +4304
- Misses 55626 55912 +286
- Partials 19361 19746 +385 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
kumarUjjawal
reviewed
Sep 6, 2026
kumarUjjawal
left a comment
kumarUjjawal
left a comment
Contributor
There was a problem hiding this comment.
Thank you @buraksenn for working on this. Just had one comment then we should we good to go.
| @@ -583,6 +583,8 @@ pub struct EmptyMessage {} | |||
| pub struct JsonWriterOptions { | |||
| #[prost(enumeration = "CompressionTypeVariant", tag = "1")] | |||
| pub compression: i32, | |||
| #[prost(uint32, optional, tag = "2")] | |||
| pub compression_level: ::core::option::Option<u32>, | |||
Contributor
There was a problem hiding this comment.
The optional protobuf field preserves binary compatibility, but adding this public Rust field breaks existing literals such as JsonWriterOptions { compression: 0 }. These now need compression_level: None or ..Default::default(). Could we correct “There are no breaking API changes” in the PR description and add a short upgrade note?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Protobuf hooks that access fields individually can silently omit newly added
state. For JSON sinks, this caused an explicitly configured compression level
to revert to the default after a physical-plan protobuf roundtrip.
Exhaustive destructuring makes newly added source, sink, and wire fields compile
errors until their serialization behavior is explicitly considered.
What changes are included in this PR?
JsonSourceandJsonSinkin their encoders.JsonSinkhook exhaustive while centralizing field mapping inits public
TryFrom<&JsonSink>conversion.compression_levelto theJsonWriterOptionsprotobuf message andpreserve it in both conversion directions.
file configuration, and sort order directly.
The protobuf change is additive and backward compatible.
Are these changes tested?
Yes. The focused JSON source and sink roundtrip tests pass:
cargo test -p datafusion-proto --test proto_integration roundtrip_jsonAre there any user-facing changes?
Physical plans containing JSON sinks now preserve an explicitly configured
compression level across protobuf roundtrips. Older payloads without the new
field continue to decode with no explicit compression level.
There are no breaking API changes.