feat: Support Spark expression hours_of_time#4860
Open
0lai0 wants to merge 3 commits into
Open
Conversation
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #3126
Supersedes #3615
Rationale for this change
Spark 4.1 introduces
TimeTypeand thehour()function on a TIME child, which resolves throughHourExpressionBuildertoHoursOfTime,RuntimeReplaceablewhose replacement isStaticInvoke(DateTimeUtils, IntegerType, "getHoursOfTime", Seq(child)).Without a shim, Comet falls back to the JVM for
hour(TIME ...)and forEXTRACT(HOUR FROM TIME ...)(which parses to the sameHoursOfTime).Note that
HoursOfTime/TimeTypedo not exist in Spark 3.4, 3.5, or 4.0 (see the datetime expression audit), so this only needs to be wired in the spark-4.1+ shim.What changes are included in this PR?
spark-4.1+
CometExprShim: matchStaticInvoke(DateTimeUtils,"getHoursOfTime", TimeType)and rewrite it to DataFusion's built-indate_part('hour', time). DataFusion'sdate_partsignature already acceptsTime64(Nanosecond)and returnsInt32, matching Spark'sIntresult. No new protobuf variant and no new native code path.native planner**: accept
LongValwithDataType::Time64(Nanosecond)so Spark 4.1 TIME literals (i64 nanoseconds-since-midnight) deserialize intoScalarValue::Time64Nanosecond, matching Arrow's storage exactly.How are these changes tested?
spark/src/test/resources/sql-tests/expressions/datetime/hour_of_time.sql./mvnw test -Dsuites="org.apache.comet.CometSqlFileTestSuite hour_of_time" -Dtest=none