fix(ui): restore Account column hyperlink routing in list views (#13639) by Chinmay048 · Pull Request #13642 · apache/cloudstack

Chinmay048 · 2026-07-17T10:43:20Z

Root Cause:
The block in ListView.vue contained an overly specific conditional check for /quotasummary that fell back to rendering a plain, unclickable for all other views, breaking general account hyperlink routing across tables.

Solution:
Added an explicit v-else-if routing check for /account to restore navigation for administrators and domain admins in non-Quota views, aligning with the existing record.owner routing architecture.

How Has This Been Tested?
Verified locally in cloud workspace:

npm run lint — 0 AST/formatting errors.

npm run test:unit — 4 test suites passed, 175 total tests passed cleanly.

…he#13639)

Copilot

Pull request overview

Restores the Account column’s router-link behavior in ListView table cells by preventing non-Quota list views from falling back to an unclickable <span> for administrators/domain admins.

Changes:

Adds an explicit /account route link for non-User roles when rendering the account column outside of QuotaSummary.
Keeps the existing QuotaSummary-specific routing to ${$route.path}/${record.accountid} when the target route exists.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

+            <router-link
+              v-else-if="$store.getters.userInfo.roletype !== 'User'"
+              :to="{ path: '/account', query: { name: text, domainid: record.domainid, dataView: true } }"
+            >{{ (record.projectname || record.account).concat(' (').concat($t('label.project')).concat(')') }}</router-link>
            <span v-else>{{ text }}</span>


weizhouapache · 2026-07-17T10:51:03Z

thanks @Chinmay048

@winterhazel could you review ?
this seems to be related by #13449

codecov · 2026-07-17T10:59:23Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 19.64%. Comparing base (75748a5) to head (0c7e66e).

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #13642      +/-   ##
============================================
- Coverage     19.65%   19.64%   -0.01%     
+ Complexity    19792    19790       -2     
============================================
  Files          6368     6368              
  Lines        575107   575107              
  Branches      70370    70370              
============================================
- Hits         113016   112997      -19     
- Misses       449808   449826      +18     
- Partials      12283    12284       +1

Flag	Coverage Δ
uitests	`3.41% <ø> (ø)`
unittests	`20.92% <ø> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

weizhouapache · 2026-07-17T12:24:07Z

@blueorangutan packge

winterhazel · 2026-07-17T13:22:48Z

@blueorangutan ui

blueorangutan · 2026-07-17T13:24:04Z

@winterhazel a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2026-07-17T13:45:03Z

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/13642 (QA-JID-962)

winterhazel

@Chinmay048 to restore the previous behavior, I would change the block that begins with <template v-if="text"> (line 693 in your commit) to:

        <template v-if="text">
          <template v-if="!text.startsWith('PrjAcct-')">
            <router-link
              v-if="$route.path.startsWith('/quotasummary')"
              :to="{ path: `${$route.path}/${record.accountid}` }">{{ text }}</router-link>
            <router-link v-else-if="record.accountid" :to="{ path: '/account/' + record.accountid }">{{ text }}</router-link>
            <router-link
              v-else-if="$store.getters.userInfo.roletype !== 'User'"
              :to="{ path: '/account', query: { name: record.account, domainid: record.domainid, dataView: true } }">
              {{ text }}
            </router-link>
            <span v-else>{{ text }}</span>
          </template>
          <template v-else-if="$route.path.startsWith('/quotasummary')">
            <router-link :to="{ path: `${$route.path}/${record.accountid}` }">
              {{ (record.projectname || record.account).concat(' (').concat($t('label.project')).concat(')') }}
            </router-link>
          </template>
        </template>

The difference is that, previously, records belonging to a project that for some reason include the account field, with the project's account, in their response did not render anything in the Account column. The way ListView.vue is now allows it to render.

Chinmay048 · 2026-07-17T15:13:53Z

Hi @winterhazel, thank you for the review! I have updated ListView.vue to use the suggested v-else-if template hierarchy for the Account column to ensure clean routing without breaking project payload rendering.

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.

winterhazel · 2026-07-17T15:30:06Z

      </template>
-
-      <template v-if="column.key === 'clustername'">
+<template v-if="column.key === 'clustername'">


@Chinmay048 could you remove this indentation change from the PR?

winterhazel · 2026-07-17T15:30:06Z

      </template>
-
-      <template v-if="column.key === 'clustername'">
+<template v-if="column.key === 'clustername'">


@Chinmay048 could you remove this indentation change from the PR?

winterhazel · 2026-07-17T15:31:28Z

          </template>
        </template>
-        <template v-if="text">
+        <template v-else-if="text">


This is changing the original behavior. Use just v-if instead.

Chinmay048 · 2026-07-18T05:22:32Z

@winterhazel,

I have pushed an updated commit that completely reverts the accidental whitespace/indentation change on the clustername block and restores v-if="text" on the Account column to preserve the original rendering behavior. Thank you for catching that!

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (2)

ui/src/components/view/ListView.vue:658

The <template v-if="column.key === 'clustername'"> line lost its indentation relative to the surrounding bodyCell templates, making this block inconsistent and harder to read. Please restore the previous indentation level.

<template v-if="column.key === 'clustername'">

ui/src/components/view/ListView.vue:697

This account link is currently rendered for any role when record.accountid is present. Elsewhere in this same account cell (e.g. the record.owner block), account navigation is restricted to non-User roles; regular users shouldn’t get a clickable account link here either.

            <router-link v-else-if="record.accountid" :to="{ path: '/account/' + record.accountid }">{{ text }}</router-link>

Copilot

Copilot was unable to review this pull request because the user who requested the review is ineligible. To be eligible to request a review, you need a paid Copilot license, or your organization must enable Copilot code review.

winterhazel · 2026-07-20T00:55:15Z

@winterhazel,

I have pushed an updated commit that completely reverts the accidental whitespace/indentation change on the clustername block and restores v-if="text" on the Account column to preserve the original rendering behavior. Thank you for catching that!

@Chinmay048 the indentation changes were still present in commit 9e98d68. I have reverted them. It looks good now. I'll just build the UI and do some manual checking before merging.

winterhazel · 2026-07-20T00:55:24Z

@blueorangutan ui

winterhazel · 2026-07-20T13:05:00Z

Trying again...

@blueorangutan ui

blueorangutan · 2026-07-20T13:06:05Z

@winterhazel a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2026-07-20T13:26:59Z

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/13642 (QA-JID-966)

winterhazel

Tested, and its looks ok.

I verified that the account column now displays a hyperlink to the respective account's details page in listings except the quota summary, and that account hyperlinks in the quota summary page still work as intended.

Account hyperlink in the instances listing

Account hyperlink in the quota summary listing

boring-cyborg · 2026-07-20T13:47:21Z

Awesome work, congrats on your first merged pull request!

fix(ui): restore Account column hyperlink routing in list views (apac…

5f29065

…he#13639)

Copilot AI review requested due to automatic review settings July 17, 2026 10:43

boring-cyborg Bot added the component:UI label Jul 17, 2026

Copilot started reviewing on behalf of Chinmay048 July 17, 2026 10:43 View session

Copilot AI reviewed Jul 17, 2026

View reviewed changes

weizhouapache added this to the 4.23.0 milestone Jul 17, 2026

winterhazel reviewed Jul 17, 2026

View reviewed changes

fix(ui): use v-else-if for Account column routing per maintainer review

4de326a

Copilot AI review requested due to automatic review settings July 17, 2026 15:11

Copilot started reviewing on behalf of Chinmay048 July 17, 2026 15:11 View session

Copilot AI reviewed Jul 17, 2026

View reviewed changes

winterhazel requested changes Jul 17, 2026

View reviewed changes

refactor(ui): revert whitespace noise and restore v-if directive

9e98d68

Copilot AI review requested due to automatic review settings July 18, 2026 05:21

Copilot started reviewing on behalf of Chinmay048 July 18, 2026 05:21 View session

Copilot AI reviewed Jul 18, 2026

View reviewed changes

Revert indentation changes

0c7e66e

Copilot AI review requested due to automatic review settings July 20, 2026 00:54

Copilot AI reviewed Jul 20, 2026

winterhazel approved these changes Jul 20, 2026

View reviewed changes

winterhazel merged commit cddd383 into apache:main Jul 20, 2026
26 of 27 checks passed

Uh oh!

Conversation

Chinmay048 commented Jul 17, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

weizhouapache commented Jul 17, 2026

Uh oh!

codecov Bot commented Jul 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

weizhouapache commented Jul 17, 2026

Uh oh!

winterhazel commented Jul 17, 2026

Uh oh!

blueorangutan commented Jul 17, 2026

Uh oh!

blueorangutan commented Jul 17, 2026

Uh oh!

winterhazel left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Chinmay048 commented Jul 17, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

winterhazel Jul 17, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

winterhazel Jul 17, 2026

Choose a reason for hiding this comment

Uh oh!

winterhazel Jul 17, 2026

Choose a reason for hiding this comment

Uh oh!

Chinmay048 commented Jul 18, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

winterhazel commented Jul 20, 2026

Uh oh!

winterhazel commented Jul 20, 2026

Uh oh!

winterhazel commented Jul 20, 2026

Uh oh!

blueorangutan commented Jul 20, 2026

Uh oh!

blueorangutan commented Jul 20, 2026

Uh oh!

winterhazel left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

boring-cyborg Bot commented Jul 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codecov Bot commented Jul 17, 2026 •

edited

Loading

winterhazel left a comment •

edited

Loading