CASSANALYTICS-68: Optimise byte array to hex string conversion - #1380
Open
architch wants to merge 2 commits into
Open
CASSANALYTICS-68: Optimise byte array to hex string conversion#1380architch wants to merge 2 commits into
architch wants to merge 2 commits into
Conversation
nob13
reviewed
Oct 28, 2025
| '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', 'a', 'b', 'c', 'd', 'e', 'f' | ||
| ) | ||
| private def byteArrayToString (x: Array[Byte]) : String = { | ||
| val result = new StringBuilder(x.length * 2) |
Contributor
There was a problem hiding this comment.
Nit: Why not using x.length * 2 + 2 and already inserting 0x ? Then you can return result.toString()
nob13
approved these changes
Oct 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change optimises byte array to hex string conversion
Current implementation uses string formatting which needs to parse the format for every byte. This takes a lot of time and CPU.
New implementation uses bit operations.
How did the Spark Cassandra Connector Work or Not Work Before this Patch
Below code demonstrates the time taken by the two implementations (>600ms to <20ms for 1Million bytearray)
General Design of the patch
Why pursue this particular fix?
We found lots of threads busy/occupied parsing the format while converting the byteArray to String in our application.
Fixes: CASSANALYTICS-68
How Has This Been Tested?
Unit Tests.
Checklist: