[CASSSIDECAR-476] Fix SpotBugs violation and add spotbugsIntegrationTest to CI#364
Closed
pauloricardomg wants to merge 2 commits into
Closed
[CASSSIDECAR-476] Fix SpotBugs violation and add spotbugsIntegrationTest to CI#364pauloricardomg wants to merge 2 commits into
pauloricardomg wants to merge 2 commits into
Conversation
pauloricardomg
changed the title
…tegrationTest Add explicit null assertion for the findJob() return value before dereferencing fields, resolving spotbugsIntegrationTest failure.
The spotbugsIntegrationTest task was not run in either CI system, allowing SpotBugs violations in integration test sources to go undetected.
pauloricardomg
force-pushed
the
CASSSIDECAR-476
branch
from
3aaed89 to
84ad018
Compare
Contributor
|
merged here 6a6b43e |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ClusterOpsDatabaseAccessorIntegrationTestby adding an explicitassertThat(...).isNotNull()before dereferencing thefindJob()return valuespotbugsIntegrationTestto CircleCI and GitHub CI lightweight integration jobs so SpotBugs violations in integration test sources are caught in CIContext
The
spotbugsIntegrationTesttask was not run in any CI pipeline:build -x integrationTest, which skips integration test SpotBugscheckstyleIntegrationTestand test execution tasksThis allowed the SpotBugs violation to go undetected during commit.