perf(semaphore): store wake batch on stack - #190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Vec<Waker>in semaphore release with a fixed 32-slot stack batchstart..endis the only initialized range, and advancingstartbefore wake lets unwind drop the remaining wakersThis is stacked on #189 so the Waker correctness changes remain independently reviewable.
A shorter
[Option<Waker>; 32]prototype regressed the empty-queuereleasebenchmark by about 18%. The finalMaybeUninithelper avoids initializing unused slots and keeps a single documented invariant.Benchmarks
Apple Silicon, medians, alternating this branch with #189 using 0.5s minimum time and 80 samples:
handoff_permitqueued_owned_burst/1queued_owned_burst/8queued_owned_burst/32releaseCommand:
cargo bench -p benchmarks --bench benchmarks -- semaphore::handoff_permit semaphore::queued_owned_burst semaphore::release --min-time 0.5 --sample-count 80 --color neverTesting
cargo +1.86.0 check -p asyncband --all-featurescargo x lintcargo x test --no-capture