fix(condvar): align notifications with standard semantics - #132
Merged
Conversation
Signed-off-by: tison <wander4096@gmail.com>
There was a problem hiding this comment.
Pull request overview
This PR reworks Condvar to follow standard condition-variable semantics (non-buffered notifications) while preserving fairness via a FIFO waiter queue, and adds documentation/tests to lock in the new behavior.
Changes:
- Replace the semaphore-backed
Condvarstate with an internal FIFO waiter queue and explicit waiter state tracking. - Update the internal
WaitListAPI to support unlink-then-remove semantics and adaptSemaphoreto the new API. - Add targeted
Condvartests for non-buffered notifications, notify-one/all behavior, and cancellation handoff; update README/CHANGELOG to reflect the new semantics.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| README.md | Updates Condvar description to match FIFO + non-buffered semantics. |
| mea/src/internal/waitlist.rs | Refactors wait list into a sentinel-based list with explicit unlink/remove operations. |
| mea/src/internal/semaphore.rs | Migrates semaphore waiter handling to the new WaitList::unlink_* / remove_unlinked_waiter API. |
| mea/src/condvar/tests.rs | Adds coverage for standard condvar notification semantics and cancellation behavior. |
| mea/src/condvar/mod.rs | Implements the new FIFO, non-buffered Condvar with cancellation-aware notify-one baton passing. |
| CHANGELOG.md | Notes the user-visible semantic change to Condvar notifications and cancellation behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing