[R][Docs] Document preserving leading zeros in partitions - #50857
[R][Docs] Document preserving leading zeros in partitions#50857tomatotomata wants to merge 1 commit into
Conversation
Signed-off-by: ahmad <ahmadalgaidy@hotmail.com>
|
Thanks for opening a pull request! This pull request has been automatically converted to a draft because its title doesn't match Arrow's required format. If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format? or After updating the title, you can mark the pull request as ready for review. See also: |
Reranko05
left a comment
There was a problem hiding this comment.
Please update the PR title and description to follow Arrow's required format.
Title:
GH-<ISSUE_NUMBER>: [<COMPONENT>] SUMMARY
PR description should include the standard sections:
- Rationale for this change
- What changes are included in this PR?
- Are these changes tested?
- Are there any user-facing changes?
Once updated, you can mark the PR as ready for review.
|
Other than @Reranko05's note above, code changes look good to me! |
There was a problem hiding this comment.
Thanks for looking at this. This change doesn't feel like it makes sense here as we end up jumping between the NYC taxi dataset and another hypothetical one. It's probably worth us thinking about where it'll make more sense for the reader. The examples for the open_dataset() function might be a better location than this vignette.
Removing approval as changes are required
Summary\n\n- document why inferred partition types can strip meaningful leading zeros\n- show the explicit hive_partition(product_id = string()) pattern\n\nThis addresses the documentation portion of #39660 and keeps the change to the R dataset vignette. I verified the patch with git diff --check; the added R example is syntactically valid. The full vignette render is not available in this checkout because the Arrow R package and its vignette dependencies are not installed.