Skip to content

[R][Docs] Document preserving leading zeros in partitions - #50857

Draft
tomatotomata wants to merge 1 commit into
apache:mainfrom
tomatotomata:codex/document-leading-zero-partitions-39660
Draft

[R][Docs] Document preserving leading zeros in partitions#50857
tomatotomata wants to merge 1 commit into
apache:mainfrom
tomatotomata:codex/document-leading-zero-partitions-39660

Conversation

@tomatotomata

Copy link
Copy Markdown

Summary\n\n- document why inferred partition types can strip meaningful leading zeros\n- show the explicit hive_partition(product_id = string()) pattern\n\nThis addresses the documentation portion of #39660 and keeps the change to the R dataset vignette. I verified the patch with git diff --check; the added R example is syntactically valid. The full vignette render is not available in this checkout because the Arrow R package and its vignette dependencies are not installed.

Signed-off-by: ahmad <ahmadalgaidy@hotmail.com>
@github-actions

Copy link
Copy Markdown

Thanks for opening a pull request!

This pull request has been automatically converted to a draft because its title doesn't match Arrow's required format.

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

After updating the title, you can mark the pull request as ready for review.

See also:

@github-actions
github-actions Bot marked this pull request as draft August 13, 2026 05:08

@Reranko05 Reranko05 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the PR title and description to follow Arrow's required format.

Title:
GH-<ISSUE_NUMBER>: [<COMPONENT>] SUMMARY

PR description should include the standard sections:

  • Rationale for this change
  • What changes are included in this PR?
  • Are these changes tested?
  • Are there any user-facing changes?

Once updated, you can mark the PR as ready for review.

uros-b
uros-b previously approved these changes Aug 15, 2026
@uros-b

uros-b commented Aug 15, 2026

Copy link
Copy Markdown
Member

Other than @Reranko05's note above, code changes look good to me!

@thisisnic thisisnic left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking at this. This change doesn't feel like it makes sense here as we end up jumping between the NYC taxi dataset and another hypothetical one. It's probably worth us thinking about where it'll make more sense for the reader. The examples for the open_dataset() function might be a better location than this vignette.

@github-actions github-actions Bot added awaiting committer review Awaiting committer review awaiting changes Awaiting changes and removed awaiting review Awaiting review labels Aug 16, 2026
@thisisnic
thisisnic dismissed uros-b’s stale review August 16, 2026 20:49

Removing approval as changes are required

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting changes Awaiting changes awaiting committer review Awaiting committer review Component: R

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants