[AMORO-4257][AMS] Fix duplicate process ID caused by multiple SnowflakeIdGenerator instances#4258
Open
felixhzhu wants to merge 1 commit into
Open
[AMORO-4257][AMS] Fix duplicate process ID caused by multiple SnowflakeIdGenerator instances#4258felixhzhu wants to merge 1 commit into
felixhzhu wants to merge 1 commit into
Conversation
…keIdGenerator instances Consolidate multiple independent SnowflakeIdGenerator instances into a single global singleton (SnowflakeIdGenerator.INSTANCE) to prevent ID collisions when two instances generate IDs in the same 10ms time window with the same machineId=0. fix apache#4257
xxubai
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix duplicate process ID generation caused by multiple independent
SnowflakeIdGeneratorinstances in the same AMS JVM.
Root Cause
Two separate static
SnowflakeIdGeneratorinstances existed:IcebergTableUtil.snowflakeIdGenerator(for optimizing process IDs)TableProcessMeta.idGenerator(for maintenance process IDs)Both used default
machineId = 0and maintained independentsequencecounters.When both entered the same 10ms time window, they generated identical IDs, causing
PRIMARY KEY conflicts in the
table_processtable.Fix
Consolidate to a single global singleton
SnowflakeIdGenerator.INSTANCE, ensuringthe
synchronizedlock andsequencecounter work correctly across all callers.How was this patch tested?
fix [Bug]: Duplicate process ID generated by multiple SnowflakeIdGenerator instances causing PRIMARY KEY conflict #4257