Skip to content

fix: reset dendrogram implement - #36

Merged
Aarebecca merged 1 commit into
masterfrom
fix/dendrogram
Dec 25, 2025
Merged

fix: reset dendrogram implement#36
Aarebecca merged 1 commit into
masterfrom
fix/dendrogram

Conversation

@Aarebecca

Copy link
Copy Markdown
Contributor
  • 将 dendrogram 的包裹节点高度恢复为 0,保持旧版仅依赖 nodeSep/subTreeSep 的布局行为,避免节点尺寸引入的间距偏移。
  • 更新所有 dendrogram 相关 SVG 快照,确保升级后结果与旧版一致。
  • 保留版本号升级改动用于发版。
  • 备注:后续可考虑引入基于 node.height/width 的尺寸感知布局,并同步调整间距/居中逻辑(当前 nodeSize 仍未参与计算)。

@gemini-code-assist

Copy link
Copy Markdown

Summary of Changes

Hello @Aarebecca, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

此拉取请求旨在修复 dendrogram 布局中的一个间距问题,该问题是由于节点尺寸意外地影响了布局计算而引起的。通过将包裹节点的高度重置为 0,我们确保了布局行为回到了仅依赖于 nodeSep 和 subTreeSep 的状态,从而消除了不必要的间距偏移。同时,更新了相关的 SVG 快照以验证此修复,并为即将发布的版本进行了版本号升级。未来可能会考虑引入更智能的尺寸感知布局。

Highlights

  • 修复树状图布局: 将 dendrogram 包裹节点的高度重置为 0,以恢复旧版仅依赖 nodeSep/subTreeSep 的布局行为,从而避免了节点尺寸引入的间距偏移问题。
  • 更新快照: 更新了所有 dendrogram 相关的 SVG 快照,以确保在布局逻辑调整后,视觉效果与旧版本保持一致。
  • 版本升级: 将 package.json 中的版本号从 0.7.0 升级到 0.7.1,为发布新版本做准备。
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

你好,感谢你的贡献。这个 PR 通过将 dendrogram 布局中包裹节点的高度重置为 0,成功修复了因节点尺寸导致的间距偏移问题,恢复了旧的布局行为。代码改动很直接,相关的快照测试也已更新,版本号也已准备好发布。这是一个很好的修复。我只在代码中添加了一个建议,希望能提高代码的可维护性。

Comment thread src/layout/dendrogram.ts
@Aarebecca
Aarebecca merged commit 56dcc56 into master Dec 25, 2025
2 checks passed
@Aarebecca
Aarebecca deleted the fix/dendrogram branch December 25, 2025 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants