Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ClaudeAPIClient.validate_api_access()used the retiredclaude-3-5-haiku-20241022model for its health check, so every run could disable Claude-based false-positive filtering even when the configured analysis model was available.This changes the health check to use
self.modeland adds a regression test that verifies the configured model is passed to the SDK.Fixes #139
Validation
python3 -m pytest -q claudecode— 174 passedpython3 -m ruff check claudecode/test_claude_api_validation.py— passedpython3 -m py_compile claudecode/claude_api_client.py claudecode/test_claude_api_validation.py— passedgit diff --check— passedThe existing
claudecode/claude_api_client.pyhas unrelated repository-wide Ruff findings; this PR does not reformat that file.Codex assistance was used to investigate and prepare this change. No live or paid API calls were made.