Skip to content

fix: normalize trailing slashes in excluded directories - #143

Open
00200200 wants to merge 1 commit into
anthropics:mainfrom
00200200:codex/security-excluded-directory-slashes
Open

00200200 wants to merge 1 commit into
anthropics:mainfrom
00200200:codex/security-excluded-directory-slashes

Conversation

@00200200

@00200200 00200200 commented Sep 14, 2026 •

Copy link
Copy Markdown

excluded-directories entries such as vendor/ and ./vendor/ never match because the matcher appends another slash. Normalize trailing separators before matching while retaining path-component boundaries. Tests exercise root and nested directories, similarly prefixed names, and empty patterns.

Validation: python -m pytest claudecode/test_github_client.py -q (============================== 29 passed in 0.55s ==============================). The regression tests fail on the unchanged main branch. Tests use local fixtures; no paid API calls.

Prepared with Codex assistance; the final diff and regression behavior were checked locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant