docs: add SSRF security review guidance - #115
Open
m4tinbeigi-official wants to merge 1 commit into
Open
m4tinbeigi-official wants to merge 1 commit into
m4tinbeigi-official wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #83.
This PR adds explicit SSRF guidance to the security review prompt.
The existing prompt already excludes path-only SSRF findings, but it does not positively describe the SSRF patterns reviewers should look for. This change adds guidance for cases where untrusted input controls the scheme/protocol, host, port, DNS target, redirect target, or full URL used by a server-side request.
It also covers common SSRF targets and bypass patterns, including localhost, link-local addresses, private network ranges, cloud metadata endpoints, redirects, DNS rebinding, alternate IP encodings, userinfo tricks, IPv6 literals, and allowlist validation gaps.
The false-positive filter is also clarified so path-only URL control remains excluded while high-signal SSRF findings involving host/protocol/full-URL control are preserved.