feat: add thermic source - #651
Merged
Merged
Conversation
# Conflicts: # pyproject.toml
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #651 +/- ##
==========================================
- Coverage 89.17% 89.06% -0.11%
==========================================
Files 47 47
Lines 11628 11801 +173
==========================================
+ Hits 10369 10511 +142
- Misses 1259 1290 +31 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
use pathlib rather than os.path
pluAtAnsys
commented
Jul 3, 2025
Signed-off-by: pluAtAnsys <pengyuan.lu@ansys.com>
Signed-off-by: Stefan Thoene <sthoene@synopsys.com>
Signed-off-by: Stefan Thoene <sthoene@synopsys.com>
Collaborator
|
@pluAtAnsys @ansmcailler i just did 2 changes: the missing loading parts should be implemented in a new test with 271 i would guess |
StefanThoene
previously approved these changes
Aug 6, 2026
echambla
reviewed
Aug 10, 2026
Signed-off-by: pluAtAnsys <pengyuan.lu@ansys.com>
docstring fix Signed-off-by: pluAtAnsys <pengyuan@synopsys.com>
…etter emittance_type
…into feat/thermicsource
…t, ie modify after reset (commit step not done so reset did not have any impact
echambla
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add thermic source in core layer inside the core.source module
Follow the existing architectural structure, using current source implementations as reference.
Ensure default values are consistent with SCDM Speos standards.
Documentation
Provide a usage example in the core module’s documentation, demonstrating how to initialize and use the new ambient source.
Testing
Create a unit test for the thermic source functionality within the core module to ensure stability and correctness.
Issue linked
Add Thermic source in core layer #540
Checklist
feat: add optical property)