Skip to content

fix: core - project - raise error if vbb is not supported by the server - #1109

Merged
echambla merged 6 commits into
mainfrom
fix/vbb-not-available-error
Aug 24, 2026
Merged

fix: core - project - raise error if vbb is not supported by the server#1109
echambla merged 6 commits into
mainfrom
fix/vbb-not-available-error

Conversation

@echambla

@echambla echambla commented Aug 21, 2026

Copy link
Copy Markdown
Collaborator

Description

  • Core layer
    Project feature
    create_simulation method: check if VBB is available on server side. If not, raise an error
  • Kernel layer
    Scene feature
    Improve the _check_texture_available so that there is no more need to create a Scene to know is the textures are available
    Indeed, starting 26r1 version, the API checkVersion is available

Issue linked

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have assigned this PR to myself.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: add optical property)
  • I have agreed with the Contributor License Agreement (CLA).

@echambla echambla self-assigned this Aug 21, 2026
@github-actions github-actions Bot added the bug Something isn't working label Aug 21, 2026
@codecov

codecov Bot commented Aug 21, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 88.89%. Comparing base (2535c8f) to head (f8e1201).

Files with missing lines Patch % Lines
src/ansys/speos/core/project.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1109      +/-   ##
==========================================
- Coverage   89.16%   88.89%   -0.27%     
==========================================
  Files          47       47              
  Lines       11623    11620       -3     
==========================================
- Hits        10364    10330      -34     
- Misses       1259     1290      +31     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread src/ansys/speos/core/project.py Outdated
pluAtAnsys
pluAtAnsys previously approved these changes Aug 23, 2026
jomadec
jomadec previously approved these changes Aug 24, 2026
@echambla
echambla dismissed stale reviews from jomadec and pluAtAnsys via 0608acf August 24, 2026 07:59
@echambla
echambla merged commit 157689a into main Aug 24, 2026
26 checks passed
@echambla
echambla deleted the fix/vbb-not-available-error branch August 24, 2026 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants