chore: Refined link map - #1085
Open
RaphaelHeiniger wants to merge 26 commits into
Open
Conversation
…tween PART, SECTION_SHELL, MAT_PIECE.., DEFINE_CURVE. Added test "pytest test_deck.py::test_reference_kwd -s" Added manually generated link_map.json that maps linkids to keywords (should be generated automatically from kwd.json at later stage)
…ord has its own linking attributes
…ecks are still required
RaphaelHeiniger
added
enhancement
Collaborator
|
I moved all this to an agents/projects folder to keep this isolated from the rest of pydyna. It now includes some further analysis by an agent, for future reference. |
|
CLA Check Failed: Commit Author Verification Unsuccessful One or more commits in this pull request contain missing or invalid author information. This issue may arise due to:
Commits with unknown authors: Please update the commit author details and push the updated commit to proceed with the CLA verification. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only link id's are not sufficiently detailed to cover all linking situations. Some links reference to different keywords depending on another field "conditional links". This branch contains the "agent_reference_revised_manual_json". It holds for each field of a keyword that represents a link the keywords which it is linking to including linking conditions if they apply.
The json is partially generated with the copilot together with the indexed manual. Additonally I crosschecked for inconsistencies and resolved most of them. However there are still inconsistent link, by crosschecking with the manual it seems this is actually the case. There is a helper script check_link_dict.py in the branch that lists inconsistent links.
We should update to the most recent kwd.json as soon as possible before finalizing this link map. Some fields name changed.
Some comments on the inconsistent links below:
-11/-12 --> links are indeed inconsistent (checked with manual)
-2 --> some keywords still use the old master / slave convention. Probably a newer kwd.json will solve this. However those links will need to be updated manually
-3 --> are indeed inconsistent (checked with manual)
-7168 CONTROL_IMPLICIT_GENERAL_DYN / CONTROL_IMPLICIT_GENERAL_SPR CNSTN is not a link according to the manual…
137 consistent an SET_IGA_FACE but with different sub keywords _XYZ or _UVW
22 could probably be unified by using GT.0 --> DEFINE_VECTOR and LT.0 --> DEFINE_COORIDNATE
83 inconsistent in case of INITIAL_VOLUME_FRACTION_GEOMETRY
85 inconsistent in DEFINE_CPM_BAG_INTERACTION in fact very special as NSPEC does not reference 1 card 1 field but a certain line in a certain card of AIRBAG_PARTICLE
97 inconsistent link (checked with manual)