feat: new action on SOP template to evaluate bsdf - #163
Open
etiennearnal wants to merge 19 commits into
Open
Conversation
Add EvaluateBSDFSlice RPC to sweep one variable (theta_in, phi_in, theta_out, phi_out, wavelength) over an equispaced range while keeping the others fixed. Returns per-sample evaluation results reusing the existing EvaluationResult structure.
Add RPC action to evaluate reflectance, transmittance and absorbance (RTA) Both global and directional
Replace per-metric RPCs (EvaluateGlobalRTA, EvaluateDirectionalRTA) with: - EvaluateAllMetrics: evaluate all metrics with kernel defaults - EvaluateMetrics: evaluate custom selection via optional MetricsConfig
Gfourneau-AS
marked this pull request as ready for review
June 17, 2026 13:44
echambla
reviewed
Jul 23, 2026
echambla
left a comment
echambla
left a comment
Collaborator
There was a problem hiding this comment.
Looks great to me. Thank you @Gfourneau-AS for your contribution.
Please wait for the overall approval before merging this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add action in SOP templates:
SOPTemplateActions::EvaluateBSDFto compute the BSDF (Bi-directional Scattering Distribution Function) for a given SOPTemplate and given impact definitions (angles, wavelength, etc.).