fix: raise cryptography floor and bump js-yaml for Guardian prod vulns - #5174
fix: raise cryptography floor and bump js-yaml for Guardian prod vulns#5174rockygeekz wants to merge 3 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 8 included reviews per hour; 5 remain after this review. 📝 WalkthroughWalkthroughThe pull request raises the ChangesDependency and schema test updates
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to The tooling dependency pin changes without altering hook configuration, and no current merge-blocking risk is identified. Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 1 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Update renovate cryptography allowedVersions to <51 via platform constraints. Adapt schema.spec.ts for js-yaml 5 ESM import and comment-only YAML files. Temporarily pin team-devtools pre-commit to constraint fix commit.
Use ansible/team-devtools@c44381c now that the constraint fix branch lives on the team repo instead of the fork.
Summary
cryptographyminimum from>=37to>=50.0.0so Guardian OSV scans stop flagging the whole legacy range.js-yamlin schema tests from 4.3.0 to 5.4.1 (CVE-2026-59870 fix is not backported to 4.x).uv.lockandtest/schemas/package-lock.json.Test plan
cd test/schemas && npm test)Summary by CodeRabbit
Chores
Tests