[P0] Harden fallback /api/runs writes to prevent forged competitive stats - #3
Open
anshgupta2000 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
sanitizeFallbackRunPayloadto normalize and clampdistance_km,duration_seconds,avg_pace,started_at, androute_data, and forceterritories_claimed: 0andis_verified: false, and export it via__internalfor testing.POST /api/runswith sanitized values and stop updatingauth_users.total_distance_kmandtotal_runsfrom client-provided data, returningis_verified: falsein the response.apps/web/src/app/api/runs/route.test.tsthat assert forgedterritories_claimed/is_verifiedare ignored and malformed fields are clamped/normalized.useRunTrackerwhen a run is saved as unverified and when a fallback save fails.Testing
src/app/api/runs/route.test.tsto validate the sanitizer logic (test file added to the repo).cd druta/apps/web && npm test -- --run src/app/api/runs/route.test.ts src/app/api/runs/live/shared.test.ts, which failed because there is notestscript inpackage.jsonon the local environment.npx vitest run src/app/api/runs/route.test.ts src/app/api/runs/live/shared.test.ts, which failed due to missing localvitestresolution/config startup errors in the current environment.Codex Task