Skip to content

docs(secret): drop VideoAside linking a private video - #6978

Open
MeGaurav4 wants to merge 1 commit into
anomalyco:devfrom
MeGaurav4:fix/6975-secret-video-private
Open

docs(secret): drop VideoAside linking a private video#6978
MeGaurav4 wants to merge 1 commit into
anomalyco:devfrom
MeGaurav4:fix/6975-secret-video-private

Conversation

@MeGaurav4

Copy link
Copy Markdown

Closes #6975

The VideoAside in the Secret component docs links
https://youtu.be/7tW2L3P6LKw, which is now private
("This is a private video"). Remove the aside until a
replacement exists.

Heads up while checking: the four other VideoAside embeds in
www/src/content/docs/docs/basics.mdx (linking resources, dev
mode, protect prod, preview environments) also resolve to
login-required players as of today. If those are intentionally
members-only, feel free to close this note; happy to strip or
swap them in a follow-up if wanted.

The "Watch a video on how secrets work" link points to a private
YouTube video, so viewers hit "This is a private video". Remove the
aside until a replacement is available.

Closes anomalyco#6975

Signed-off-by: MeGaurav4 <gaurav3.141592@gmail.com>

@omercnet omercnet left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed the linked Secret video is private and the one-line removal is in the correct TypeDoc source. Regenerated the component docs: the Secret page no longer emits the broken VideoAside, and the complete website build succeeds. The other private VideoAside links noted in the description are pre-existing and outside issue #6975.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Broken link in "Secret" documentation

2 participants