Disable VCS metadata in Go lambda and bridge task builds - #6976
Open
MaTTaDox wants to merge 1 commit into
Open
Conversation
Follow-up to anomalyco#6607, which added -buildvcs=false to the bridge lambda but left the remaining two Go builds stamped. Go records vcs.revision/vcs.time into every main package, so a new commit alone changes the bytes of the built binary. For user Go lambdas the zip hash therefore changes on every commit, and since a function's code object is keyed by that hash (assets/<name>-code-<hash>.zip), every deploy replaces every code object and updates every function - even when no Go source changed. For the bridge task it needlessly busts the image cache. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #6607
Go records
vcs.revision/vcs.timeinto every main package, so a new commit alone changes the binary's bytespkg/runtime/golang/golang.go— user Go lambdasplatform/scripts/build— the bridge taskVerified: two builds at one commit are byte-identical,
-buildvcs=falsechanges the bytes,gofmtclean, package compiles.