Fix durable workflow imports with Yarn PnP - #6973
Open
wengkhing wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
SST Workflow applications can fail before synthesis under Node 22 and Yarn PnP when a config imports a module that imports
sst/aws/workflow.The durable SDK ESM entrypoint statically imports named exports from the CommonJS
@aws-sdk/client-lambdapackage. Yarn PnP exposes that package through a CommonJS loader, so Node rejects the import before SST can evaluate the config:This blocks
sst diff,sst deploy, andsst devfor otherwise valid durable workflow applications.Fix
Load the durable SDK through Node
createRequire()while retaining type-only imports. This selects the SDK CommonJS entrypoint, which works with Yarn PnP and preserves the existing durable SDK version and SSTworkflowAPI.Testing
bun run typecheck:sdkbun run build:sdksst/aws/workflow