fix commonjs require of unenv aliases in cloudflare worker bundling - #6950
Open
beeirl wants to merge 1 commit into
Open
fix commonjs require of unenv aliases in cloudflare worker bundling#6950beeirl wants to merge 1 commit into
beeirl wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the cloudflare worker bundler passes unenv aliases straight to esbuild. any commonjs dep that requires an aliased shim (
debug,inherits,node-fetch, ...) gets the esm namespace object instead of the default export, which breaks at runtime and fails the upload with error 10021. one example:hash.jsdoesrequire("inherits"), aliased to the esm-onlyunenv/npm/inherits, soutils.inheritsis an object instead of a function.this adds an esbuild plugin that routes require() resolutions of
unenv/npm/*andunenv/mock/*aliases through a small cjs facade: default export when present, named exports copied over. esm imports keep the existing alias behavior. same approach wrangler ships since cloudflare/workers-sdk#6932.verified with
go test ./pkg/runtime/worker, the regression test bundles and executes default export, named export, and esm cases.