Propagate sendCode typescript definition from Code UI to Code Provider - #308
Open
mschinis wants to merge 1 commit into
Open
Propagate sendCode typescript definition from Code UI to Code Provider#308mschinis wants to merge 1 commit into
sendCode typescript definition from Code UI to Code Provider#308mschinis wants to merge 1 commit into
Conversation
Author
|
@thdxr could I get a review on this please? |
andrewmd5
added a commit
to 6over3/openauth
that referenced
this pull request
Apr 26, 2026
Cherry-picks from anomalyco/openauth open PRs: - anomalyco#305 spec-compliant redirect_uri (require `allow`, RFC 9700 §4.1) - anomalyco#309 client-side JWT audience validation (RFC 7519 §4.1.3) - anomalyco#318 token_type=Bearer on token responses - anomalyco#304 implicit-flow no refresh token (RFC 6749 §4.2.2) - anomalyco#258 iat claim (deterministic across reuse interval) - anomalyco#323 fix Cloudflare KV runaway key creation under eventual consistency - anomalyco#315 loosen CloudflareStorageOptions to structural KV shape - anomalyco#319 refresh callback hook - anomalyco#156 OAuth2 scope (authorize, token, well-known, JWT claim) - anomalyco#236 basePath option - anomalyco#278 allowRegistration / userExists / allowClaims - anomalyco#221 configurable Select copy - anomalyco#310 anomalyco#308 code UI resend action + sendCode types - anomalyco#325 example actions: keep session when access token still valid - anomalyco#317 add MIT license to package.json Bump 0.3.12 -> 0.4.0 (breaking: `allow` is now required).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a quick fix to propagate the correct typescript definition, defined in CodeProviderOptions, to CodeUIOptions.
I would like to make a check during
sendCodeexecution to check if the user is registered within our system. In order to do that, I tried returningCodeProviderErrorobject fromsendCodeas defined in CodeProviderOptions, but I got a typescript error even though my implementation actually worked.Upon further investigation, it seems that the two definitions of
sendCodewithin CodeUI and CodeProvider are different.Since the
sendCodemethod is passed from CodeUI to CodeProvider, the two typescript definitions for the same method should match.An alternative to this approach, and likely better, would be to update
CodeUIOptions.sendCodedefinition to be the same asCodeProviderOptions["sendCode"]