Updating snippet to use coil3 artifact - #1030
Conversation
yrezgui
left a comment
yrezgui
left a comment
There was a problem hiding this comment.
I need to check why we have both of these dependencies
| implementation(libs.androidx.fragment.ktx) | ||
| implementation(libs.androidx.work.runtime.ktx) | ||
| implementation(libs.coil.kt.compose) | ||
| implementation(libs.coil3.compose) |
There was a problem hiding this comment.
I'm a bit confused why we're adding coil3 as a dependency without changing the import; see the usages.
There was a problem hiding this comment.
Please either remove the implementation or add the coil3 import.
There was a problem hiding this comment.
Removed the library from this module.
| implementation(libs.androidx.fragment.ktx) | ||
| implementation(libs.androidx.work.runtime.ktx) | ||
| implementation(libs.coil.kt.compose) | ||
| implementation(libs.coil3.compose) |
There was a problem hiding this comment.
Why are we adding these libraries in this module? The imports are still referecing coil2
There was a problem hiding this comment.
Removed the library from this module.
| import androidx.compose.ui.res.stringResource | ||
| import androidx.compose.ui.tooling.preview.Preview | ||
| import coil.compose.AsyncImage | ||
| import coil3.compose.AsyncImage |
There was a problem hiding this comment.
Why aren't we updating all the imports in the compose module to reference coil3?
There was a problem hiding this comment.
I believe I've updated all the imports in the Compose module now to reference coil3.
| # Coil 2 | ||
| coil = "2.7.0" |
There was a problem hiding this comment.
might want to remove this
5 participants
Updating snippet to use coil3 artifact.