Skip to content

Add heading semantics to TopAppBar titles for accessibility #1019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
paulsowden wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add heading semantics to TopAppBar titles for accessibility #1019

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 17 additions & 5 deletions compose/snippets/src/main/java/com/example/compose/snippets/components/AppBar.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,8 @@ import androidx.compose.runtime.saveable.rememberSaveable
import androidx.compose.runtime.setValue
import androidx.compose.ui.Modifier
import androidx.compose.ui.input.nestedscroll.nestedScroll
import androidx.compose.ui.semantics.heading
import androidx.compose.ui.semantics.semantics
import androidx.compose.ui.text.style.TextOverflow
import androidx.compose.ui.tooling.preview.Preview
import androidx.compose.ui.unit.dp
Expand Down Expand Up @@ -196,7 +198,10 @@ fun SmallTopAppBarExample() {
titleContentColor = MaterialTheme.colorScheme.primary,
),
title = {
Text("Small Top App Bar")
Text(
"Small Top App Bar",
modifier = Modifier.semantics { heading() },
)
}
)
},
Expand Down Expand Up @@ -226,7 +231,8 @@ fun CenterAlignedTopAppBarExample() {
Text(
"Centered Top App Bar",
maxLines = 1,
overflow = TextOverflow.Ellipsis
overflow = TextOverflow.Ellipsis,
modifier = Modifier.semantics { heading() },
)
},
navigationIcon = {
Expand Down Expand Up @@ -273,7 +279,8 @@ fun MediumTopAppBarExample() {
Text(
"Medium Top App Bar",
maxLines = 1,
overflow = TextOverflow.Ellipsis
overflow = TextOverflow.Ellipsis,
modifier = Modifier.semantics { heading() },
)
},
navigationIcon = {
Expand Down Expand Up @@ -320,7 +327,8 @@ fun LargeTopAppBarExample() {
Text(
"Large Top App Bar",
maxLines = 1,
overflow = TextOverflow.Ellipsis
overflow = TextOverflow.Ellipsis,
modifier = Modifier.semantics { heading() },
)
},
navigationIcon = {
Expand Down Expand Up @@ -360,6 +368,7 @@ fun TopBarNavigationExample(
title = {
Text(
"Navigation example",
modifier = Modifier.semantics { heading() },
)
},
navigationIcon = {
Expand Down Expand Up @@ -413,7 +422,10 @@ fun AppBarSelectionActions(

TopAppBar(
title = {
Text(topBarText)
Text(
topBarText,
modifier = Modifier.semantics { heading() },
)
},
colors = TopAppBarDefaults.topAppBarColors(
containerColor = MaterialTheme.colorScheme.primaryContainer,
Expand Down