feat: add python3.14 support, drop python3.9/3.10 support - #75
Merged
Conversation
setup.py's get_requirements()/VERSION_FILE opened requirements.txt and version.py via bare relative paths, relying on the build's working directory matching the package root. That happened to hold under python3.13's build isolation but broke under python3.14's (newer setuptools resolved into the isolated build env no longer chdirs the same way): FileNotFoundError: requirements.txt, discovered while bumping env_nap_time's Lambda runtime to 3.13/3.14 and hitting this as a transitive install failure. Anchor both paths to setup.py's own directory (matching get_long_description(), which already did this correctly) so the build no longer depends on the invoking process's cwd, regardless of which setuptools version ends up resolved. Also declares the 3.14 classifier and extends tox/CI to actually test against it, following the same pattern as #73 (python3.13 support). Verified: `pip install .` and the full test suite (58/58) pass under a real python3.14 interpreter -- not just declared support. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
aoskotsky-amplify
marked this pull request as ready for review
July 17, 2026 03:41
Raise the floor to python3.11 -- matching #73's precedent of bundling a version-support change alongside a drop (that PR added 3.13 and dropped 3.8 in one commit). No compat-shim code depended on <3.11 (checked; none found), so this is purely a metadata/tooling change: - setup.py: python_requires >=3.11.0, drop the 3.9/3.10 classifiers - tox.ini: drop py39/py310 from envlist - .github/workflows/test-build-publish.yml: drop 3.9/3.10 from the matrix - .pre-commit-config.yaml: mypy --python-version 3.9 -> 3.11 - pyproject.toml: ruff target-version py39 -> py311 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
aoskotsky-amplify
changed the title
jconstance-amplify
approved these changes
Jul 17, 2026
jconstance-amplify
left a comment
jconstance-amplify
left a comment
Contributor
There was a problem hiding this comment.
technically 3.10 is still in support for a few more months
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why (3.14 support)
Discovered while bumping
env_nap_time's Lambda runtime to python3.13/3.14 (itsamplify-aws-utils>=0.5,<0.6install failed under a fresh python3.14 environment):setup.py'sget_requirements()andVERSION_FILEopenedrequirements.txt/version.pyvia bare relative paths, relying on the build's working directory matching the package root. That held under python3.13's build isolation but breaks under python3.14's -- a newer setuptools resolved into the isolated build environment no longerchdirs the same way, so the read fails with:Anchored both paths to
setup.py's own directory viaTHIS_DIRECTORY = os.path.abspath(os.path.dirname(__file__)), matchingget_long_description(), which already did this correctly. This makes the build independent of the invoking process's cwd regardless of which setuptools version ends up resolved -- not just a python3.14-specific patch.Why (drop 3.9/3.10)
No compat-shim code in the package depended on <3.11 (checked; none found), so raising the floor is a pure metadata/tooling change with no code impact. Bundled into this PR rather than opening a second one, matching #73's precedent.
Changes
setup.py:python_requires>=3.9.0->>=3.11.0; classifiers drop 3.9/3.10, add 3.14tox.ini: envlist dropspy39/py310, addspy314.github/workflows/test-build-publish.yml: matrix drops3.9/3.10, adds3.14.pre-commit-config.yaml: mypy--python-version3.9->3.11pyproject.toml: rufftarget-versionpy39->py311Test plan
pip install .succeeds under a real python3.14 interpreter (previously failed with the FileNotFoundError above)ruff check/ruff format --checkclean under the newtarget-version--python-version=3.11, etc.) pass on both commits🤖 Generated with Claude Code