Repository navigation
Implement optimistic mark-all-read with rollback and add tests - #705
Open
titilope12 wants to merge 1 commit into
Open
titilope12 wants to merge 1 commit into
titilope12 wants to merge 1 commit into
Conversation
- Fix useMutateMarkAllRead to handle both cache shapes (paginated and single-page) via NotificationCacheEntry union and markAllAsRead helper. - Add onRollback that restores notification caches and unread count on failure; zero unread count immediately on optimistic update. - Return error for inline error display matching useMarkNotificationRead. - Fix useApiMutation cancelQueries to fire-and-forget (thenable never settles in test env with no in-flight queries, blocking mutation). - Add 3 MSW-based tests: optimistic update, rollback on error, unread count zeroing. 🤖 Generated with Codebuff Co-Authored-By: Codebuff <noreply@codebuff.com>
|
@titilope12 is attempting to deploy a commit to the sheriffamina1-9497's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@titilope12 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Owner
|
@titilope12 please kindly fix your ci issue |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Generated with Codebuff
Closes #620
Closes #609
Closes #623
Closes #608