Conversation
There was a problem hiding this comment.
Pull request overview
Reorganizes the project demo by moving the client UI into a dedicated demo/client Vite app and updating root scripts/docs to run the demo from the repo root.
Changes:
- Replace the previous root-level demo entry files (
index.tsx,index.html,index.css) with a new Vite-powered demo client underdemo/client. - Add root npm scripts to install/run/verify the demo (server + client) in parallel.
- Update README with local demo run instructions and regenerate lockfiles accordingly.
Reviewed changes
Copilot reviewed 12 out of 14 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Updates dev/demo scripts to support running demo/server and demo/client workflows. |
| package-lock.json | Reflects dependency/script changes (notably removing nodemon) and a regenerated lockfile. |
| index.tsx | Removes the old root-level demo React entrypoint. |
| index.html | Removes the old root-level demo HTML entrypoint. |
| index.css | Removes the old root-level demo stylesheet. |
| demo/client/vite.config.ts | Adds Vite config for the new demo client app. |
| demo/client/tsconfig.node.json | Adds TS config for Vite config tooling in the demo client. |
| demo/client/tsconfig.json | Adds strict TS config for the demo client source. |
| demo/client/src/main.tsx | Adds the new demo client React entrypoint using react-text-stream. |
| demo/client/src/index.css | Adds the demo client styling. |
| demo/client/package.json | Defines the demo client package and links the library via file:../... |
| demo/client/package-lock.json | Adds lockfile for demo client dependencies. |
| demo/client/index.html | Adds demo client HTML entrypoint. |
| README.md | Documents how to run the demo locally and available demo scripts. |
Files not reviewed (1)
- demo/client/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <html> | ||
| <head> | ||
| <title>React Event Stream</title> | ||
| </head> |
There was a problem hiding this comment.
index.html is missing a <!doctype html> declaration. Without it, the page can render in quirks mode, which can cause inconsistent layout/styling across browsers. Add <!doctype html> at the top of the document (and consider adding a charset meta tag as well).
| color: lightblue; | ||
| border: 1px solid white; | ||
| padding: 10px; | ||
| box-shadow: lightblue; |
There was a problem hiding this comment.
box-shadow: lightblue; is not valid CSS for box-shadow (it requires offsets/blur/spread). As written, it will be ignored by browsers. Replace it with a valid box-shadow value or remove the property.
| box-shadow: lightblue; | |
| box-shadow: 0 0 4px lightblue; |
No description provided.