fix(terminal): honor Num Lock for keypad navigation - #199
Open
malekelkssas wants to merge 1 commit into
Open
malekelkssas wants to merge 1 commit into
malekelkssas wants to merge 1 commit into
Conversation
bvolpato
reviewed
Sep 25, 2026
bvolpato
left a comment
Collaborator
There was a problem hiding this comment.
The Num Lock-off behavior you tested makes sense. One compatibility edge: mapping KP_End to keycode 115 makes embedded Ghostty see ordinary End, not keypad End. That changes keybind matching and Kitty keyboard sequences for apps that distinguish keypad keys; Ghostty's GTK host keeps this as numpad_end. Can we preserve keypad identity while producing navigation? The embedded API only accepts a native keycode today, so this may need follow-up there. I would not block this fix on that edge alone, but wanted to make the tradeoff explicit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
Reproduction
On KDE Plasma Wayland with Limux 0.1.30, turn Num Lock off and press keypad 1 in a terminal prompt. Limux types
1, while Konsole treats the same key as End.Verification
./scripts/check.shpassed on the clean base and after the change.1with Num Lock on.