Skip to content

fix(Employee): make approver setting more flexible - #52

Merged
PatrickDEissler merged 1 commit into
version-15from
flexible-approvers
Aug 7, 2026
Merged

fix(Employee): make approver setting more flexible#52
PatrickDEissler merged 1 commit into
version-15from
flexible-approvers

Conversation

@PatrickDEissler

Copy link
Copy Markdown
Collaborator

Fix:
Don't always set the approver fields based on reports_to. Only set if empty. This way, we avoid empty approvers and set some sort of default.

But:
We allow users to change the approvers to someone else.

@PatrickDEissler
PatrickDEissler marked this pull request as ready for review August 7, 2026 08:19
@greptile-apps

greptile-apps Bot commented Aug 7, 2026

Copy link
Copy Markdown

Confidence Score: 5/5

The PR appears safe to merge with no concrete blocking or independently actionable non-blocking issues identified.

The changed fallback assignment preserves configured approvers while still populating empty fields from Reports To, and the accompanying property setters and translation updates are consistent with that behavior.

Reviews (1): Last reviewed commit: "fix(Employee): make approver setting mor..." | Re-trigger Greptile

@PatrickDEissler
PatrickDEissler merged commit b076439 into version-15 Aug 7, 2026
6 checks passed
@PatrickDEissler
PatrickDEissler deleted the flexible-approvers branch August 7, 2026 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant