feat: add Edit on GitHub link to documentation pages - #19
Merged
Conversation
Confidence Score: 4/5The PR is not yet safe to merge because stale remote-tracking metadata can expose an Edit on GitHub link that targets a deleted branch. Branch selection validates cached local Git metadata rather than the branch's current existence in the configured GitHub repository, so a deleted branch can still be embedded in the edit URL. Files Needing Attention: compendium/docs.py Prompt To Fix All With AI### Issue 1
compendium/docs.py:612
**Stale remote ref breaks link**
If a canonical remote branch is deleted after the checkout last fetched it, the locally cached remote-tracking ref still passes this check, causing the displayed Edit on GitHub link to target the deleted branch and open a 404.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Reviews (4): Last reviewed commit: "fix: resolve GitHub edit branch from the..." | Re-trigger Greptile |
|
What about Private Repos? |
Member
Author
Users will be told by GitHub that they don't have edit access. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.