Skip to content

Added ability to specify direction to the 'setAllowScrolling' method. - #48

Open
sparkison wants to merge 2 commits into
alvarotrigo:masterfrom
sparkison:master
Open

sparkison wants to merge 2 commits into
alvarotrigo:masterfrom
sparkison:master

Conversation

@sparkison

Copy link
Copy Markdown

Updated code to take direction arguments for the setAllowScrolling method as in fullPage.js
Felt this was a missing, and a needed feature.

@sparkison

Copy link
Copy Markdown
Author

Set fixed. Confirmed working.

@alvarotrigo

Copy link
Copy Markdown
Owner

Thanks for it!

@alvarotrigo

Copy link
Copy Markdown
Owner

Could you commit it again after updating your copy? I can not merge it anymore.

@sethsacher

Copy link
Copy Markdown

Where does this stand? This would be a handy feature for my site!

@alvarotrigo

Copy link
Copy Markdown
Owner

@sethsacher it was never merged.

I would encourage you to make use of fullPage.js instead, where this feature is implemented (and many others! )

I put much more time and effort on it and you can emulate the pagePiling.js behaviour by using the Parallax extension and using offset:100. Then placing your content within the fp-bg element.

A related article about it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants