Repository navigation
fix(browser): prevent concurrent recording finalization deadlocks - #18
Merged
Merged
Conversation
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
…d teardown Co-authored-by: cursoragent <cursoragent@cursor.com> No-Mistakes-Model: gpt-5.6-luna-low
…sites Co-authored-by: cursoragent <cursoragent@cursor.com> No-Mistakes-Model: gpt-5.6-terra-medium
Co-authored-by: cursoragent <cursoragent@cursor.com> No-Mistakes-Model: gpt-5.6-terra-medium
Co-authored-by: Codex <noreply@openai.com>
This was referenced Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notes
Closes #11. Final head verification before publication: independent whole-change review passed; 20/20 independent retry-disabled focused runs passed in 14s using npx vitest run src/browser/ffmpeg-wrapper.test.ts src/utils/exec.test.ts src/commands/start.test.ts --retry=0; npm run build passed; npm test -- --retry=0 passed 37 files / 606 tests in 164.09s; npm run test:ffmpeg passed. Duplicate local build/test/document/lint gate steps are skipped because that evidence is already retained and the isolated v1.52 gate worktree has no node_modules; required GitHub CI remains enabled for the exact published head.
Summary
Agent-browser 0.34.0 can stall while finalizing overlapping recordings because FFmpeg progress output is not drained. ProofShot now prepares immutable per-resolved-FFmpeg wrappers on Linux and macOS with
-nostats -loglevel error, preserving FFmpeg errors while preventing the recorder pipe from filling; recording fails closed when the wrapper cannot be prepared or on Windows.What Changed
PATHduringstart, while retaining subprocess diagnostics from stderr.Risk Assessment
✅ Low: The bounded change routes pinned
agent-browserrecording through atomic per-FFmpeg quiet wrappers and explicitly rejects unsupported Windows recording.Testing
Pipeline
Updates from git push no-mistakes
Config sources:
global@sha256:33741f468eee✅ **Intent** - passed
agenttrue✅ No issues found.
✅ **Rebase** - passed
✅ No issues found.
✅ **Review** - passed
✅ No issues found.
⏭️ **Build** - skipped
Step was skipped.
⏭️ **Test** - skipped
Step was skipped.
⏭️ **Document** - skipped
Step was skipped.
⏭️ **Lint** - skipped
Step was skipped.
✅ **Push** - passed
git push --force-with-lease=refs/heads/codex/quiet-agent-browser-recording:c9ffbd6a02218197d97bb03414f05b8e69192f46 git@github.com:alvarohulse/proofshot.git 6ba0ead619110e7ecb0788dcb615f07053ef43c2:refs/heads/codex/quiet-agent-browser-recording— passed (exit 0)✅ No issues found.