Wire the alert channel into the dial-home agent - #39
Merged
Conversation
The agent built its Supervisor without an alerter, so a worker that dialed home never fired Slack/webhook/email alerts even with the channels configured. Build make_alerter(settings) once in run_agent, pass it to the initial Supervisor, and thread it through swap_supervisor so a policy hot-swap keeps the same channel.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up from the 0.4.0 audit:
make_alerterwas wired intorun/watch/servebut not the dial-homeagent, so an in-cluster worker never fired alerts.run_agentbuildsmake_alerter(settings)once and passes it to the initialSupervisor.swap_supervisorgains analerterparam so a policy hot-swap keeps the same channel.Test:
swap_supervisorthreads the alerter onto the new supervisor's engine. 265 passed; ruff/mypy clean.