restart-count probe + elpio pod_ref (FEAT-5, FEAT-7) - #33
Merged
Conversation
FEAT-7: a `restart-count` probe flags crash-looping pods -- CrashLoopBackOff, an OOMKilled last state, or restartCount >= max_restarts (default 5) -- the common "up but unhealthy" signals a readiness check misses between restarts. The detail names the worst container and why. FEAT-5: the elpio probes gain pod_ref() so `l` (logs), `s` (shell), and inspect work on elpio targets. ElpioService uses the knative pod label (serving.knative.dev/service, its default engine); ElpioTask uses elpio's canonical elpio.io/service label on its KEDA dispatcher pods. ElpioFunction stays without one (it is a build; the produced service is supervised separately). PVC-usage and cert-expiry from the same task are deferred: PVC usage needs kubelet volume stats kubectl does not expose, and cert parsing needs a dep the hardened image avoids. Tracked for a follow-up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
restart-countprobe: unhealthy on CrashLoopBackOff, an OOMKilled last-state, orrestartCount >= max_restarts(default 5). Registered inPROBES.pod_ref()sol/s/inspect work on elpio targets:ElpioService→serving.knative.dev/service=<name>(default knative engine),ElpioTask→elpio.io/service=<name>(KEDA dispatcher pods, verified against elpio's engines).ElpioFunctionstays without one (it's a build).Deferred (same task, follow-up): PVC-usage needs kubelet volume stats kubectl doesn't expose; cert-expiry needs a cert-parsing dep the hardened image avoids.
Tests: 6 restart-count cases (healthy/threshold/CrashLoop/OOMKilled/no-pods/refs) + elpio pod_ref params. 229 passed; ruff/mypy clean. Tasks #23, #25 (partial).