[DO NOT MERGE] Flexible pages structure with content - #4725
Closed
andysellick wants to merge 7 commits into
Closed
andysellick wants to merge 7 commits into
andysellick wants to merge 7 commits into
Conversation
- not yet complete, will need an actual mechanism to generate the correct breadcrumbs
- wraps the flexible sections in the govuk-grid - may want to adapt later to toggle this depending on the flexible section, but good starting point
- adds the heading component and lead paragraph component, and hooks them up to show the right content
- adds the model and frontend code to display rich text with contents lists flexible sections - again preliminary as we want to auto generate contents lists, but a decent starting point
- adds an example content item for the history of No.10 page, using the new flexible sections - also incomplete, still needs breadcrumbs, and a better way of handling images (currently just hard coding the image paths from the live site)
Contributor
Author
|
@KludgeKML here's my code so far. Happy if you want to keep working on your branch and I'll keep up, or if you want to review this and merge it into your branch. |
KludgeKML
force-pushed
the
flexible-pages-structure
branch
10 times, most recently
from
April 3, 2025 10:44
32661d8 to
73ae6db
Compare
KludgeKML
force-pushed
the
flexible-pages-structure
branch
from
April 8, 2025 11:44
73ae6db to
9a6f93a
Compare
KludgeKML
force-pushed
the
flexible-pages-structure
branch
10 times, most recently
from
April 28, 2025 16:02
3faaca5 to
16d3be6
Compare
KludgeKML
force-pushed
the
flexible-pages-structure
branch
2 times, most recently
from
April 30, 2025 13:56
ad426c2 to
48f8c96
Compare
Contributor
Author
|
@KludgeKML I think this PR isn't needed anymore, so closing. |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds some frontend onto the back of the initial scaffolding for the flexible page type.
Why
Spiking into how this can work.
Visual differences
Trello card: https://trello.com/c/lzs5JraY