Fix issue in quantization - #7
Conversation
| @@ -1,14 +1,19 @@ | |||
| { | |||
| "name": "allanpichardo/mysql-vector", | |||
| "name": "askibinski/mysql-vector", | |||
There was a problem hiding this comment.
This file shouldn't get changed in the PR
There was a problem hiding this comment.
yes the PR is wrong, thanks for pointing out
|
|
||
| return $this->binaryToHexadecimal($padded); | ||
| } | ||
| private function vectorToHex(array $vector): string { |
There was a problem hiding this comment.
Can public stay public please? Otherwise we can no longer extend. Or at least protected instead of private, but either way seems like a bit of scope creep here
|
This works well; Given this list of items:
Before the PR a search for 'Warm dessert' gets Chocolate cake first, but Tomato soup second. Ie, secondary results are closer vector in relation after the PR as far as I can tell. Beyond that added some minor comments |
scotteuser
left a comment
scotteuser
left a comment
There was a problem hiding this comment.
Looks good to me, thanks! 'Approved' FWIW :)
|
See #8 for the new PR from a different branch (Needed the main branch) |
2 participants
This fixes the quantization issue as described and fixed by @therealgaxbo (thank you kind stranger!) on reddit:
https://www.reddit.com/r/PHP/comments/1dwcjig/comment/lc296ud/